Re: [PATCH] s390 (2/7): common i/o layer.

[Christoph Hellwig]

On Mon, Oct 06, 2003 at 11:24:48AM +0200, Martin Schwidefsky wrote:
> +static void
> +chp_release(struct device *dev)
> +{
> +}
> +
>  /*
>   * Entries for chpids on the system bus.
>   * This replaces /proc/chpids.
> @@ -863,8 +869,10 @@
>  	/* fill in status, etc. */
>  	chp->id = chpid;
>  	chp->state = status;
> -	chp->dev.parent = &css_bus_device;
> -
> +	chp->dev = (struct device) {
> +		.parent  = &css_bus_device,
> +		.release = chp_release,
> +	};

Eek.  How is the dummy release function supposed to help
anything?  you must free the object in ->release.  Also
the assignment is horrible as hell.

Dito for the following patches.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/