Re: [PATCH] s390 (2/7): common i/o layer.

From: Christoph Hellwig
Date: Mon Oct 06 2003 - 09:46:05 EST


On Mon, Oct 06, 2003 at 04:40:06PM +0200, Martin Schwidefsky wrote:
>
> Hi Christoph,
>
> > Eek. How is the dummy release function supposed to help
> > anything? you must free the object in ->release. Also
> > the assignment is horrible as hell.
>
> Just checked. You right about chp_release which should do
> a kfree on the struct channel_path object. But the two
> other release functions are really dummy functions because
> cu3088_root_dev and iucv_root are static structures.

Even in that case you're screwed in case they are in modules..

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/