Re: [RFC 1/6] sysfs-kobject.patch

From: Greg KH
Date: Mon Oct 06 2003 - 11:19:37 EST


On Mon, Oct 06, 2003 at 02:30:03PM +0530, Maneesh Soni wrote:
> diff -puN include/linux/kobject.h~sysfs-kobject include/linux/kobject.h
> --- linux-2.6.0-test6/include/linux/kobject.h~sysfs-kobject 2003-10-06 11:48:37.000000000 +0530
> +++ linux-2.6.0-test6-maneesh/include/linux/kobject.h 2003-10-06 11:48:51.000000000 +0530
> @@ -32,6 +32,12 @@ struct kobject {
> struct kset * kset;
> struct kobj_type * ktype;
> struct dentry * dentry;
> + struct list_head k_sibling;
> + struct list_head k_children;
> + struct list_head attr;
> + struct list_head attr_group;
> + struct rw_semaphore k_rwsem;
> + char *k_symlink;
> };

Ouch. Like Al said, this is too bloated. Remember, not all kobjects
are registered for use in sysfs. This makes the overhead for such
usages pretty high :(

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/