Re: [PATCH] Poll-based IDE driver

[Andre Hedrick]

The rules are different in POLLing.

Totally different state machine, and nothing seen here to date.
You can not call any kernel services you can not depend upon.

Using altstat is actually required but that is another day.

Andre Hedrick
LAD Storage Consulting Group

On Wed, 8 Oct 2003, Dave Jones wrote:

> On Wed, Oct 08, 2003 at 09:36:36AM -0700, Andre Hedrick wrote:
>  > 
>  > Does not matter, priority is to get content to platter and the hell with
>  > everything else.
> 
> I don't buy this. Without correct udelay()'s, how is code like this..
> 
>         for (i = 0; i < 10; i++) {
>                 dump_udelay(1);
>                 if (OK_STAT((stat = hwif->INB(IDE_STATUS_REG)), good, bad))
>                         return 0;
>         } 
> 
> expected to work ? It won't wait for 10usec at all, but be over almost instantly.
> Ramming commands at the drive before its status has settled doesn't strike
> me as a particularly safe thing to do.
> 
> 		Dave
> 
> -- 
>  Dave Jones     http://www.codemonkey.org.uk
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/