Re: [PATCH] Fix mlockall for PROT_NONE mappings

[Andi Kleen]

On Thu, Oct 09, 2003 at 12:49:18PM +0200, Muli Ben-Yehuda wrote:
> On Thu, Oct 09, 2003 at 12:42:18PM +0200, Andi Kleen wrote:
> 
> > I added a new argument force==2 to get_user_pages that means to ignore
> > SIGBUS or unaccessible pages errors. MAY_* is still checked for like
> > with the old force ==1, it just doesn't error out now for SIGBUS
> > errors on handle_mm_fault. 
> 
> How about making it an enum or define for code readability? I'd much
> rather see an IGNORE_BAD_PAGES or some such than a cryptic '2' in the
> code. I can send a patch to that effect if you'd like? 

Doesn't look essential. You could submit it as a follow-up patch as soon
as Linus merged this version, but I'm not sure it satisfies the current
"no more cleanups" rule because it isn't a bugfix.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/