Re: [PATCH] laptop mode

From: Jens Axboe
Date: Thu Oct 09 2003 - 09:07:29 EST


On Thu, Oct 09 2003, Jeff Garzik wrote:
> Linux Kernel Mailing List wrote:
> >ChangeSet 1.1150.1.52, 2003/10/08 10:49:45-03:00, axboe@xxxxxxx
> >
> > [PATCH] laptop mode
> >
> > Hi Marcelo,
> >
> > Lots of people have been using this patch with great success, and
> > it's
> > been in the SuSE kernel for some months now too. It is also in the
> > -benh
> > ppc tree
> >
> > Basically, it introduces a write back mode of dirty and journal data
> > that is more suitable for laptops. At the block layer end, it
> > schedules
> > write out of dirty data after the disk has been idle for 5 seconds.
> >
> > Laptop mode can be switched on and off with /proc/sys/vm/laptop_mode.
> > There is also a block_dump sysctl, which if enabled will dump who
> > dirties and writes out data. This is very helpful in pinning down
> > who is
> > causing unnecessary writes to the disk.
>
> Red Hat just dropped this patch since it was suspected of data
> corruption ;-(

Eh? Care to explain a bit further? I'm not aware of any data corruption
issues there, and it's certainly simple enough to easily audit.

And how kind of Red Hat to not inform me of any suspicion in this
regard.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/