Re: [PATCH] net/sunrpc/clnt.c compile fix

From: Paul Mundt
Date: Thu Oct 09 2003 - 11:42:04 EST


On Thu, Oct 09, 2003 at 12:37:49PM -0400, Trond Myklebust wrote:
> > This is due to the fact that tk_pid is protected by
> > RPC_DEBUG. Wrapping through dprintk() fixes this.
>
> No... You are suppressing legitimate warning messages that inform the
> user of a client/server mismatch!
>
> Better then to remove the tk_pid from the warning messages...
>
Is there any reason why tk_pid needs to be under RPC_DEBUG in the first place?
If these are legitimate warning messages, presumably it would be nice to know
the offending pid as well.

Attachment: pgp00001.pgp
Description: PGP signature