Re: [PATCH] BUG() in exec_mmap()

From: Mika Penttilä
Date: Thu Oct 09 2003 - 16:07:38 EST




Marcelo Tosatti wrote:

On Thu, 9 Oct 2003, Dave Kleikamp wrote:



Marcelo,
A recent change to exec_mmap() removed the initialization of old_mm,
leaving an uninitialized use of it. This patch would completely remove
old_mm from the function. Is this what was intended?



Yes.

Blame me... patch applied, thank you!

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/



Hmm.. you still need to mmput(old_mm) etc, just remove the mm_users == 1 optimization from the beginning of exec_mmap, so this patch is wrong!

--Mika


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/