Re: [PATCH] laptop mode

From: Jens Axboe
Date: Sat Oct 11 2003 - 09:01:23 EST


On Sat, Oct 11 2003, Pavel Machek wrote:
> Hi!
>
> > > Right now laptopmode/aam is just a suspect. There are still 1-2 other
> > > small patches against IDE which could be the reason. We've dropped
> > > laptopmode/aam for the time being to see if the folks seeing repeatable
> > > corruption suddenly start behaving again.
> >
> > aam patch is far more risky, it's a far more likely suspect. That patch
> > never reall did go out of beta. Dropping laptop-mode and aam at the same
> > time is bad engineering practice :).
> >
> > laptop-mode cannot cause corruption that cannot show otherwise.
>
> Well, if fireballs have data-corrupting that happens just after spinup
> (for example), I can see how laptop-mode affects that. W/o
> laptop-mode, disk is spinning all the time so sleep bugs can not
> manifest themselves. You add laptop-mode, and...

Not very likely, imho. People have been using spin down with hdparm for
years (in Linux and elsewhere), while acoustic management is a bit more
esoteric.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/