Re: [RFC] invalidate_mmap_range() missesremap_file_pages()-affected targets

From: Andrew Morton
Date: Sun Oct 12 2003 - 06:55:38 EST


William Lee Irwin III <wli@xxxxxxxxxxxxxx> wrote:
>
> It would seem that mincore() shares a similar issue on account of its
> algorithm

Yes, I think it makes sense to fix mincore(). I don't fully understand the
reasoning behind the three cases though:

+ if (pte_file(*pte))
+ present = mincore_linear_page(vma, pte_to_pgoff(*pte));
+ else if (!(vma->vm_flags | (VM_READ|VM_WRITE|VM_MAYREAD|VM_MAYWRITE)))
+ present = pte_present(*pte);
+ else
+ present = mincore_linear_page(vma, pgoff);

Could you explain the logic behind each of these? Perhaps with permanent
comments?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/