Re: [SCSI] Set max_phys_segments to sg_tablesize

[Jens Axboe]

On Wed, Oct 15 2003, David S. Miller wrote:
> On Wed, 15 Oct 2003 15:37:22 +0300
> <mika.penttila@xxxxxxxxxxx> wrote:
> 
> > >It does matter if the driver can't cope with it.
> > 
> > But this fix may hurt performance with well behaving drivers in
> > iommu systems. It's better to fix the broken drivers I think. 
> 
> That's absolutely correct.
> 
> If you add Herbert's change, you will effectively turn off all
> of the IOMMU coalescing benefits we designed into the block layer.
> Please don't apply it, fix the broken drivers instead.

Just changing it to hw segments should be fine, but I agree phys
segments is the wrong check.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/