Re: [ANNOUNCE] udev 003 release

[Greg KH]

On Fri, Oct 17, 2003 at 11:19:23AM -0700, Greg KH wrote:
> 
> Ah, yeah, udev seg faults right now for partitions.  Let me try to track
> down the bug, give me a bit of time...

Here's a patch that fixes the partition logic for me.  Sorry about this, I
need to make sure to test partitions more next time.

thanks again for testing this.

greg k-h

# fix segfaults when dealing with partitions.

diff -Nru a/udev-add.c b/udev-add.c
--- a/udev-add.c	Fri Oct 17 11:26:37 2003
+++ b/udev-add.c	Fri Oct 17 11:26:37 2003
@@ -169,13 +169,13 @@
 	}
 	memset(&dbdev, 0, sizeof(dbdev));
 	strncpy(dbdev.name, attr.name, NAME_SIZE);
-	strncpy(dbdev.sysfs_path, class_dev->sysdevice->directory->path,
-		PATH_SIZE);
+	if (class_dev->sysdevice) {
+		strncpy(dbdev.sysfs_path, class_dev->sysdevice->directory->path, PATH_SIZE);
+		strncpy(dbdev.bus_id, class_dev->sysdevice->bus_id, ID_SIZE);
+	}
 	strncpy(dbdev.class_dev_name, class_dev->name, NAME_SIZE);
-	if ((sysfs_get_name_from_path(subsystem, dbdev.class_name, NAME_SIZE))
-	    != 0)
+	if ((sysfs_get_name_from_path(subsystem, dbdev.class_name, NAME_SIZE)) != 0)
 		strcpy(dbdev.class_name, "unkown");
-	strncpy(dbdev.bus_id, class_dev->sysdevice->bus_id, ID_SIZE);
 	strcpy(dbdev.bus_name, "unknown");
 	if (class_dev->driver != NULL)
 		strncpy(dbdev.driver, class_dev->driver->name, NAME_SIZE);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/