Re: Finding memory leak

From: Holger Kiehl
Date: Sun Oct 19 2003 - 02:49:22 EST


On Sat, 18 Oct 2003, Jörn Engel wrote:

> On Sat, 18 October 2003 19:23:53 +0200, Jörn Engel wrote:
> > >
> > > - Could someone please check igmpv3_newpack() and assure me that there
> > > is no leak.
> >
> > There was a leak, found by the stanford checker team. I've provided a
> > broken fix, DaveM wanted to write a decent one. Not sure if it has
> > already found it's way into the official kernel.
>
> If DaveM hasn't fixed it yet, you can also try this patch. Since I'm
> pretty unaware of the networking code, this may be broken again, but
> it also can't make things much worse for you.
>
I cannot use this patch since I am using 2.4.22, and there igmpv3_newpack()
looks a bit different. I also cannot test 2.6.0-test since the driver for
the DVB card is only for 2.4.x.

But your patch did go in, looking at 2.6.0-test8 there now is a
kfree_skb(skb).

Holger

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/