Re: Patch to add support for SGI's IOC4 chipset

[Jeremy Higdon]

On Thu, Oct 16, 2003 at 08:20:51PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 
> > I will be on a vacation starting tomorrow, so I won't be able to reply
> > until Oct 19th or 20th, in case there are any more issues.  Hopefully this
> > one will be okay  :-)
> 
> I think that after applying attached incremental patch it can go in.

Thanks.  I'll test this and reply with the results.

> - defining IDE_ARCH_ACK_INTR and ide_ack_intr() in sgiioc4.c is a no-op,
>   it should be done <asm/ide.h> to make it work
>   (I think the same problem is present in 2.4.x)

The definition in <include/linux/ide.h> is only used if IDE_ARCH_ACK_INTR is
not defined.  sgiioc4.c defines IDE_ARCH_ACK_INTR before including that file,
so I believe we get the definition we want without touching ide.h, don't we?

> - fix NULL pointer dereference (accessing hwif->name while hwif is NULL)
>   in sgiioc4_ide_setup_pci_device() (was this driver ever tested?)

Yes.  It may be that since name is an array, the value passed to request_region
was the offset of name in the structure.  Since that was never dereferenced,
things worked okay.  In any case, the code was obviously incorrect.

> - make config option SN2 specific
> - replace uint{8,32,64}_t by u{8,32,64}

These look fine.

I'll await a response on the IDE_ARCH_ACK_INTR issue.  Do you want me to send
another patch, or is the previous with your update sufficient?

thanks

jeremy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/