Re: [BUG somewhere] 2.6.0-test8 irq.c, IRQ_INPROGRESS ?

From: Marcelo Tosatti
Date: Thu Oct 23 2003 - 06:30:39 EST




On Wed, 22 Oct 2003, Linus Torvalds wrote:

>
> On Wed, 22 Oct 2003, M.H.VanLeeuwen wrote:
> >
> > I'm seeing an NMI Watchdog detected LOCKUP go away when I revert this patch
> > previously added into test8.
>
> Yes, the thing is buggy.
>
> It's not correct for "disable_irq_nosync()" users, and reverting it is the
> right thing to do. Thanks for the report.
>
> Marcelo, please note if you played with this in 2.4.x..

2.4.23-pre8 does clear IRQ_INPROGRESS in setup_IRQ() (it fixes the IDE setup
hang viro mentioned).

disable_irq_nosync() doesnt care about IRQ_INPROGRESS. I cant figure out why
does the change breaks...





-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/