Re: diethotplug-0.4 utility patch

From: Greg KH
Date: Fri Oct 24 2003 - 00:45:26 EST


On Thu, Oct 23, 2003 at 08:46:11PM +0200, David Jez wrote:
> Hi Greg,
>
> I send you patch for diethotplug-0.4, witch:
> - adds remove action

Hm, remove action will not work. See the linux-hotplug-devel mailing
list archives for why we can not do this.

> - adds pci.rc & usb.rc

Why do you need this? What's wrong with a small shell script to do
this? Are you using this for a system? I guess it could be useful for
a system that has no shell.

> - usb.rc script remove modules not by fixed list as hotplug, but from
> list gotten from depend files when compiled

I don't understand, what does this do?

> - for USB: matching by vendor & class, not only by vendor (-ENODEV bug)

Can you split this patch out? It looks useful.

> +++ diethotplug-0.4/convert_ieee1394.pl Thu Apr 10 11:16:00 2003
> @@ -54,4 +54,3 @@
> }
>
> print "\t{NULL}\n};\n";
> -

Hm, you have a few diffs like this, I don't think it's really necessary
:)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/