Re: [PATCH,RFC] umsdos FS in 2.6.x

From: viro
Date: Fri Oct 24 2003 - 04:17:31 EST

On Thu, Oct 23, 2003 at 11:53:27PM -0700, Randy.Dunlap wrote:
> This patch enables umsdos filesystem to build, although a few things
> still need to be fixed, such as:
> . updating {acm}time, since those fields changed from time_t to
> struct timespec: for backward compatibility, do these fields
> need to remain as time_t (i.e., keep the same size) ?
> . I kept using a 16-bit dev_t. Does this need to change?
> If yes, to 32-bit, or to use whatever size is passed to it?
> . fill_super/read_super probably still need a little bit of work,
> such as which inode_operations structure to use.
> . I'll begin testing it soon.

* struct inode reuse between msdos and umsdos is FUBAR. Allocation/freeing
of inode is controlled by its ->i_sb. So is location of struct inode within
the allocated object. That's where umsdos got really broken and AFAICS the
only more or less sane way to handle that crap is separation of msdos and
umsdos inode/dentry/superblock, so that the latter would refer the former.

The rest is more or less trivial; compile fixes, mostly from prototype changes
for methods. Inode reuse problem is where the real PITA is and it will take
a serious work to fix.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at