Re: [PATCH 2.4.23-pre8] Remove broken prefetching in free_one_pgd()

From: Dave Jones
Date: Sun Oct 26 2003 - 09:53:03 EST


On Sat, Oct 25, 2003 at 10:10:10PM +0200, Pavel Machek wrote:

> > This patch was accepted into 2.5.55, attributed to "davej@uk".
> Dave Jones?n

Yep.

> > This code will prefetch from beyond the end of the page table
> > being cleared ... which is clearly a bad thing if the page table
> > in question is allocated from the last page of memory (or precedes
> > a hole on a discontig mem system).
> Prefetching random addresses should be safe...

It isn't on some CPUs. Early athlons go bang when you prefetch
past the end of RAM into unmapped memory for eg.

Dave

--
Dave Jones http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/