Re: Linux 2.6.0-test9, aic7xxx [passed]

From: P. Christeas
Date: Mon Oct 27 2003 - 15:18:50 EST



> "P. Christeas" <p_christ@xxxxxx> wrote:
> > One more, (as reported a few weeks ago):
> > rmmod aic7xxx
> > will fail, as this module uses some wrong locks. This will also block
> > sleeping (tested w. ACPI) if the module is there.
> > IMHO this module is crucial to many systems.
>
> The rmmod works OK for me, in the sense that the module is removed, the
> kernel doesn't crash and the module can be reloaded.
>
> But yes, there are several locking problems in there:
>
> - ahc_free() now sleeps, deep down in the kobject layer somewhere (it
> calls /sbin/hotplug).
>
> This is a likely fix for that:
>

You 're right. I just tested -test9 and it can fully rmmod the module. I
recall that in -test5, 7 the module wouldn't be cleaned, but now it's OK. The
warnings (enabled by the .config option) still appear (several of them). I am
on a UP, however and don't know if a SMP system would happen to have trouble.
I'll also give your patch a try.

Thanks.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/