Re: [BIO] Bounce queue in bio_add_page

From: Jens Axboe
Date: Tue Nov 04 2003 - 04:06:50 EST


On Tue, Nov 04 2003, Herbert Xu wrote:
> On Tue, Nov 04, 2003 at 09:49:30AM +0100, Jens Axboe wrote:
> >
> > That could work, but it breaks the rule that counts are always accurate.
>
> Yes, it means that recount may return a higher value but it is never
> lower.

Precisely. Historically, that would have caused panics in some drivers
even though it is safe :)

> I think it should be safe though as recount is not always called (it is
> only called if the phys/hw segments exceed the limits). In the cases
> where it is not called you may be looking at an overestimate anyway.

I think it is safe too, just want to make absolutely sure.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/