Re: [PATCH] use NODES_SHIFT to calculate ZONE_SHIFT

From: Jesse Barnes
Date: Fri Nov 07 2003 - 17:31:08 EST

On Fri, Nov 07, 2003 at 01:58:06PM -0800, Andrew Morton wrote:
> jbarnes@xxxxxxx (Jesse Barnes) wrote:
> >
> > Now that we have a proper NODES_SHIFT value, we need to use it to define
> > ZONE_SHIFT otherwise we'll spill over 8 bits if we have more than 85
> > nodes. How does this look? The '+2' should really be
> > log2(MAX_NR_NODES), but I think this is an improvement over what was
> > there.
> You mean log2(MAX_NR_ZONES).

Yep, sorry.

> How about we do it this way, so at least the duplicated information is on
> adjacent lines, and they are unlikely to get out of sync?

Yeah, this looks great.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at