Re: 2.6.0-test9-bk16 ALi M5229 kernel boot error

[viro]

On Tue, Nov 11, 2003 at 07:04:17PM -0800, Linus Torvalds wrote:
 
> Yes. The ALI driver has some really strange code to avoid tweaking non-ALI 
> southbridges. 
> 
> But the thing is, it breaks even _with_ ALI southbridges, if we just don't 
> find the ALI bridge we expect.
> 
> Does this patch fix it?
> -	if (north && north->vendor != PCI_VENDOR_ID_AL) {
> +	if (!isa_dev) {

Wrong fix, AFAICS.  Original condition is bogus, no arguments here.
However, the point is
	"tweak our southbridge only if northbridge is known to be OK with that"
and not
	"tweak southbridge only if it's ours"

IOW, proper check is || of those two.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/