Re: file2alias - incorrect? aliases for USB

[Greg KH]

On Mon, Nov 10, 2003 at 01:26:39PM +0300, "Andrey Borzenkov"  wrote:
> > I would suggest just ignoring the bcdDevice value, and loading all
> > modules that match the idVendor and idProduct values, and let the kernel
> > sort it out :)
> > 
> > So for your example, you would just:
> > 	modprobe usb:v04E6p0006dl*dh*dc*dsc*dp*ic*isc*ip* 
> > 
> 
> any reason we put in alias fields that apparently won't be used
> at all?

Hm, don't know.  I didn't think of these as ranges, which some of the
fields are.  Possibly we might want to drop those variables from the
strings.

> > Hm, but that's no good either, because the visor driver trips over that
> > with its entry:
> > 	MODULE_ALIAS("usb:v*p*dl*dh*dc*dsc*dp*ic*isc*ip*");
> > and the improper module is loaded.  That needs to be fixed up...
> > 
> > Rusty, any reason why the module alias code is turning an empty
> > MODULE_PARAM structure, as is declared in drivers/usb/serial/visor.c
> > with the line:
> >         { },                                    /* optional parameter entry */ 
> > 
> > Into the above MODULE_ALIAS?  I don't think that's correct.
> > 
> 
> Subject:  [PATCH][2.6.0-test9] prevent catch-all USB aliases in modules.alias
> 
> http://marc.theaimsgroup.com/?l=linux-kernel&m=106787897124700&w=2

Ah, missed that.  Care to send it to Rusty?  It looks like a simple,
needed fix.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/