Re: OT: why no file copy() libc/syscall ??

From: Trond Myklebust
Date: Tue Nov 18 2003 - 11:26:42 EST


>>>>> " " == Andi Kleen <ak@xxxxxxx> writes:

>> > That would be buggy because existing users of sendfile don't
>> > know about this and would silently only copy part of the file
>> > when a signal happens.
>>
>> That doesn't make sense. There aren't any existing users of
>> sendfile to copy files.

> [ignore the mail, it was an stuck mail queue]

> But note that arbitary changes in the signal handling would
> affect all users of sendfile, not just those that attempt to
> copy files or do other things that should be done in user
> space.

That 'change' is already in effect for people who mount their NFS
partitions with the "intr" or "soft" flags.

See the return value of generic_file_sendfile(): it already has the
read()/write-like semantics of returning number of bytes written if
non-zero, or the value of desc.error if not.

Cheers,
Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/