Re: [PATCH] make 2.6 megaraid recognize intel vendor id

From: Sam Ravnborg
Date: Wed Nov 19 2003 - 14:14:38 EST


Hi Christoph, nice rewrite.

Minor comments - which is not not specific for ypur clean-up, but maybe
worth addressing now?

> +#ifdef CONFIG_PROC_FS
> + if (adapter->controller_proc_dir_entry) {
> + remove_proc_entry("stat", adapter->controller_proc_dir_entry);
> + remove_proc_entry("config",
> + adapter->controller_proc_dir_entry);
remove_proc_entry is an empty do {} while, so the ifdef is not needed.

> +#if MEGA_HAVE_ENH_PROC
Looks like a potential CONFIG option?

> +#ifdef CONFIG_PROC_FS
> + remove_proc_entry("megaraid", &proc_root);
> +#endif
ifdef not needed.

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/