Re: Silicon Image 3112A SATA trouble

[Jeff Garzik]

Jens Axboe wrote:
> On Sun, Nov 30 2003, Jeff Garzik wrote:
>
> > Jens Axboe wrote:
> >
> > > > Well, the constraint we must satisfy is
> > > >
> > > > 	sector_count % 15 != 1
> > >
> > >
> > > 	(sector_count % 15 != 1) && (sector_count != 1)
> > >
> > > to be more precise :)
> >
> >
> > Thanks for the clarification, I did not know that.
> >
> > Avoiding sector_count==1 requires additional code :(  Valid requests 
> > might be a single sector.  With page-based blkdevs requests smaller than 
> > a page would certainly be infrequent, but are still possible, with bsg 
> > for example...
>
>
> You misread it... sector_count == 1 is fine, sector_count % 15 == 1 is
> ok when sector_count is 1 (it would have to be, or sector_count == 1
> would not be ok :)


Ahh, duh.  Thanks again.  Yeah, it makes sense since the bug arises from 
too-large Serial ATA data transactions on the SATA bus...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/