2.4.23-bk bogus edd changeset - Re: 2.4.23 compile error in edd

From: Anton Altaparmakov
Date: Thu Dec 04 2003 - 17:38:35 EST


2.4.23-bk has a changeset (post 2.4.23 release TAG) that makes edd not
compile as Meelis Roos already reported:

On Thu, 4 Dec 2003, Meelis Roos wrote:
> gcc -D__KERNEL__ -I/home/mroos/compile/linux-2.4/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686 -nostdinc -iwithprefix include -DKBUILD_BASENAME=setup -DEXPORT_SYMTAB -c setup.c
> setup.c: In function `copy_edd':
> setup.c:734: error: `DISKSIG_BUFFER' undeclared (first use in this function)
> setup.c:734: error: (Each undeclared identifier is reported only once
> setup.c:734: error: for each function it appears in.)
> make[1]: *** [setup.o] Error 1
> DISKSIG_BUFFER is nowhere to be seen.

Further, looking at the header files the closest constant that does exist
is #define DISK80_SIG_BUFFER 0x228 from include/asm-i386/edd.h.

However, changing DISKSIG_BUFFER to DISK80_SIG_BUFFER causes the kernel to
reboot the computer as soon as it starts booting. Basically I select it
in grub and the screen changes graphics mode and by the time it has
finished the switch the computer reboots.

2.4.23-bk at the 2.4.23 release TAG works fine and compiles fine with the
same .config.

Best regards,

Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer / IRC: #ntfs on irc.freenode.net
WWW: http://linux-ntfs.sf.net/ & http://www-stu.christs.cam.ac.uk/~aia21/
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/