Re: [BUG 2.4] NFS unlocking operation accesses invalid file struct

From: Akinobu Mita
Date: Tue Dec 09 2003 - 20:11:51 EST


Hello Trond,

I apologize for the delay in responding.

On Friday 28 November 2003 01:23, Trond Myklebust wrote:
> So then the correct thing to do is indeed to wrap the call to
> locks_unlock_delete() with an fget()/fput() pair, and then to remove
> the test for fl_pid in locks_same_owner().
>
> We then need to fix lockd so that it generates correct fl_owners for
> its locks...
>
> Let me see if I can get that right.
>

I looked at your patch carefully
(http://www.fys.uio.no/~trondmy/src/Linux-2.4.x/2.4.23-rc1/linux-2.4.23-01-posix_race.dif)
and I think it would fix the problem completely.

Thanks,

--
Akinobu Mita

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/