Re: [Patch 1/4] fs.h: b_journal_head

From: Joe Thornber
Date: Wed Dec 10 2003 - 03:49:12 EST


On Wed, Dec 10, 2003 at 10:46:55AM +1100, Nathan Scott wrote:
> Could you explain a bit more about when b_private should and
> shouldn't be used with this change?

Once the io goes through generic_make_request() you shouldn't look at
bh->b_private until the io has completed. At which point it will have
been correctly set back to the value it had when submitted.

The problem with jbd wasn't the fact that it used it, but the fact
that it peeked while the io was in flight.

This is ugly I know, much cleaner in 2.6 where there is a split
between bh and bio.

- Joe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/