Re: [linux-usb-devel] Re: [OOPS, usbcore, releaseintf] 2.6.0-test10-mm1

From: Greg KH
Date: Thu Dec 11 2003 - 04:27:00 EST


On Thu, Dec 11, 2003 at 09:49:54AM +0100, Duncan Sands wrote:
>
> Hi Greg, what I meant was: should I make my patch friendlier to rmmod by
> trying hard to drop the reference as soon as possible, though some code paths
> may have to hold on to it for a long time (cost: code complication), or is it OK
> to always hang onto the usb_device as long as one of the usbfs files is open
> (cost: rmmod may take a long or infinite time; advantages: simple, robust)?

If the file is open, keep the reference count. If you were to try
anything else, it would just be to complex in the end.

It's ok to wait a long time on rmmod, that's a pretty unique situation.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/