Re: [Oops] i386 mm/slab.c (cache_flusharray)

From: Manfred Spraul
Date: Fri Dec 12 2003 - 15:09:00 EST


Christoph Hellwig wrote:

Looks like whe're better of fixing mm/slab.c

Maybe I'm blind, but I don't see how kmem_cache_alloc can return NULL with __GFP_NOFAIL:
- kmem_cache_alloc calls __cache_alloc.
- cache_alloc only return 0 if cache_alloc_refill returns 0.
- cache_alloc_refill only return 0 if cache_grow returns 0.
- cache_grow only return 0 if
* SLAB_NO_GROW is set in flags.
* get_free_pages(flags) fails.
* kmem_cache_alloc(flags&SLAB_LEVEL_MASK) fails.
SLAB_LEVEL_MASK contains __GFP_NOFAIL.

--
Manfred


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/