Re: [DOCUMENTATION] Revised Unreliable Kernel Locking Guide

From: Keith Owens
Date: Fri Dec 12 2003 - 19:29:07 EST


On Fri, 12 Dec 2003 18:25:56 +0000,
Dave Jones <davej@xxxxxxxxxx> wrote:
>On Sat, Dec 13, 2003 at 03:25:52AM +1100, Keith Owens wrote:
> > Also calls to smp_call_function() need to be wrapped in preempt_disable,
> > plus any work that is done on the current cpu before/after calling a
> > function on the other cpus. Lack of preempt disable could result in
> > the operation being done twice on one cpu and not at all on another.
>
>And where you want to do the same thing on every processor, there's a
>handy on_each_cpu() which takes care of this for you.

I know, but there is code in 2.6 that calls smp_call_function directly,
without preempt disable around it.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/