Re: PCI Express support for 2.4 kernel

[Richard B. Johnson]

On Mon, 15 Dec 2003, Vladimir Kondratiev wrote:

> Richard B. Johnson wrote:
> <discussion regarding initializers for static vars>
>
> Let's stop this discussion, it leads to nowhere. Probable, yes,
> initializer do add bytes to the data segment. But it does not make
> difference for memory image after loading, do it?
>

It definitely does. It makes the difference between having stuff
work or not in many embedded systems.

> Does this difference in executable size worth potential risk of error?
>
> Anyway, common style in kernel seems to be to do initialize static vars,
> even to 0. There are plenty of examples, including the same file, (for
> 2.4.23)
>
> arch/i386/kernel/pci-pc.c:32
> static int pci_using_acpi_prt = 0;
>

This is a BUG. This wastes space that may end up being embedded
in NVRAM, then copied to RAM. If it was not initialized, it would
never exist in NVRAM at all.

> or
>
> arch/i386/kernel/setup.c:1241
> static int tsc_disable __initdata = 0;
>

This is not a BUG because "__initdata" is defined to be in a segment
that is initialized and discarded after use.

> Finally, let's stop this thread. Let it be up to person who will be (if
> it will happen) checking this code into kernel, to decide on coding
> style. I, personally, value code clarity more then 4 bytes in executable
> size. But I will not object if more experienced kernel maintainers have
> another priority.
>
> Vladimir.
>

It's not style. It's misuse of variables and well-defined
conventions. Often data is not some simple variable, but an
aggregate type such as a structure or an array. FYI "style"
relates to naming conventions and where you put curley braces.
Even that is supposed to be controlled to some liberal extent.

static long xtable[0x100] = {0,};

MUST be in the .data segment, while...

static long xtable[0x100];

MUST be in the .bss segment, while...

static const long xtable[0x100]={0,1,2,3,4,5,6,7,8,9,.....};

MUST be in the .const segment. It's that simple. If you
violate that, your code will only work by fiat, i.e., it
was defined to work, not designed to work.


Cheers,
Dick Johnson
Penguin : Linux version 2.4.22 on an i686 machine (797.90 BogoMips).
            Note 96.31% of all statistics are fiction.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/