Re: [PATCH 2/2][RFC] Add dm-crypt target

From: Rusty Russell
Date: Mon Dec 22 2003 - 22:26:02 EST


On Mon, 22 Dec 2003 22:52:36 +0100
Christophe Saout <christophe@xxxxxxxx> wrote:

> Hi,

Hi Christophe!

One anal comment:
> +/*
> + * module hooks
> + */
> +module_init(dm_crypt_init)
> +module_exit(dm_crypt_exit)

Please use semicolons here. It's nicer C-looking, and it means we don't have
to do silly things in the macros.

Thanks,
Rusty.
--
there are those who do and those who hang on and you don't see too
many doers quoting their contemporaries. -- Larry McVoy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/