Re: Problem with dev_kfree_skb_any() in 2.6.0

[Jeff Garzik]

David S. Miller wrote:
> On Tue, 30 Dec 2003 00:15:19 -0500
> Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
>
>
> > OK, agreed.  But fixing it in the driver is still incorrect, also.
> >
> > We need a single solution in the net stack, not a per-driver solution.
>
>
> I totally disagree.
>
> Let's quickly review, this is illegal:


You're missing the point.

Think about the name of this function:  dev_kfree_skb_any()

If this function cannot be used -anywhere-, then the concept (and the 
net stack) is fundamentally broken for this function.  We must _remove_ 
the function, and thus _I_ have a lot of driver work to do.

[jgarzik@sata linux-2.5]$ find . -name '*.[ch]' -type f | grep -v SCCS | 
xargs grep -wl dev_kfree_skb_any | wc -l
     71

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/