Re: 2.6.0 kernel panic

[Isaac Claymore]

On Mon, Dec 29, 2003 at 10:42:06PM -0800, Linus Torvalds wrote:
> 
> 
> On Mon, 29 Dec 2003, Murray J. Root wrote:
> > On Sat, Dec 27, 2003 at 09:07:59PM -0500, Murray J. Root wrote:
> > > P4 2GHz
> > > ASUS P4S533 mainboard
> > > 1G PC2700 RAM
> > > GF2 GTS video using nv driver
> > > 2.6.0 compiled with gcc 3.3.2
> > > 
> > > At boot kernel gets:
> > >    INIT: cannot execute "/etc/rc.d/rc.sysinit"
> > > then panic.
> > > 
> > > Same configuration for 2.6.0-test11 and earlier works fine.
> > > 
> > 
> > To answer myself, I did a diff between 2.6.0-test11 and 2.6.0. Found this:
> 
> Sounds like one of the partitions that has the executable script loader is
> mounted with "noexec". 
> 
> On most systems, /etc/rc.d/rc.sysinit is a bash script, and explicitly
> points to /bin/bash. Check "ldd /bin/bash", and verify that all the
> libraries (and /bin itself, of course) are mounted on executable
> filesystems.
> 
> That would be a bug that 2.6.0 uncovers. 

I've noticed that 2.4.23 lacks this additional check, and included a
patch against it.

Marcelo, does this trivial stuff look good enough to be applied?


-Isaac

> 
> 		Linus
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 

Regards, Isaac
()  ascii ribbon campaign - against html e-mail
/\                        - against microsoft attachments
--- mmap.c	2003-12-05 09:39:09.000000000 +0800
+++ mmap.c.execproto	2003-12-31 11:25:12.000000000 +0800
@@ -17,6 +17,7 @@
 
 #include <asm/uaccess.h>
 #include <asm/pgalloc.h>
+#include <linux/mount.h>
 
 /*
  * WARNING: the debugging will use recursive algorithms so never enable this
@@ -400,8 +401,13 @@ unsigned long do_mmap_pgoff(struct file 
 	int error;
 	rb_node_t ** rb_link, * rb_parent;
 
-	if (file && (!file->f_op || !file->f_op->mmap))
-		return -ENODEV;
+	if (file) {
+		if (!file->f_op || !file->f_op->mmap)
+			return -ENODEV;
+
+		if ((prot & PROT_EXEC) && (file->f_vfsmnt->mnt_flags & MNT_NOEXEC))
+			return -EPERM;
+	}
 
 	if (!len)
 		return addr;