Re: swapper: page allocation failure. order:3, mode:0x20

From: Anton Blanchard
Date: Thu Jan 01 2004 - 17:56:51 EST



> This seems a bit odd. It means that the further apart the message bursts
> are, the longer they are allowed to be. Or something.
>
> Wouldn't it be better to say "after each greater-than-five second window,
> allow up to ten printk's as long as they happen in the next five
> milliseconds"?

Its 100% copied from the networking code. I would have thought we really
want that behaviour, if Im on a serial console I can only tolerate a
decent sized backtrace every few seconds. If I allow 10 bursts every 5
seconds then im screwed.

Instead we allow the burst of 10 once but then ratelimit it to one
per 5 seconds until we have had a long enough period of silence. The
main thing is that over the long term we have an average of one message
per 5 seconds.

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/