Re: [patch against 2.6.1-rc1-mm1] replace check_region with request_region in isp16.c

From: Muli Ben-Yehuda
Date: Sat Jan 03 2004 - 12:30:31 EST


On Sat, Jan 03, 2004 at 06:06:20PM +0100, Jesper Juhl wrote:

> One thing that surprised me was that the isp16 driver does not seem to
> ever call request_region, it only ever calls check_region which confuses
> me a bit - wouldn't it need to (also with older kernels) always call
> request_region ?

I think so. It looks broken as it was, playing with the IO region
without requesting it first. Is anyone actually using this driver?

> I would appreciate it is someone could take a quick look at the patch and
> verify that it does the correct thing.

Looks correct to me.

Chers,
Muli
--
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/

"the nucleus of linux oscillates my world" - gccbot@#offtopic

Attachment: signature.asc
Description: Digital signature