Re: [PATCH] Remove Intel check in i386 HPET code

[Vojtech Pavlik]

On Sun, Jan 04, 2004 at 02:13:50PM +0100, Andi Kleen wrote:
> 
> The i386 HPET time setup code would explicitely check for the Intel
> vendor ID. That is bogus because other chipset vendors (like AMD) 
> are implementing HPET too. 
> 
> Remove this check.

You can also remove the HPET_ID_VENDOR_8086 definition.

> 
> -Andi
> 
> diff -u linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c
> --- linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c~	2004-01-04 14:10:59.000000000 +0100
> +++ linux-2.6.1rc1-bk3-ia32/arch/i386/kernel/time_hpet.c	2004-01-04 14:10:59.000000000 +0100
> @@ -91,10 +91,6 @@
>  	    !(id & HPET_ID_LEGSUP))
>  		return -1;
>  
> -	if (((id & HPET_ID_VENDOR) >> HPET_ID_VENDOR_SHIFT) !=
> -				HPET_ID_VENDOR_8086)
> -		return -1;
> -
>  	hpet_period = hpet_readl(HPET_PERIOD);
>  	if ((hpet_period < HPET_MIN_PERIOD) || (hpet_period > HPET_MAX_PERIOD))
>  		return -1;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/