Re: 2.6.1-rc1-tiny1 tree for small systems

[viro]

On Sun, Jan 04, 2004 at 05:00:49PM -0700, Eric W. Biederman wrote:

1) make block-based filesystems dependent on CONFIG_BLOCK

> --- linux-2.6.1-rc1-tiny1.eb1/fs/super.c	Wed Dec 17 19:58:48 2003
> +++ linux-2.6.1-rc1-tiny1.eb2/fs/super.c	Sun Jan  4 15:18:28 2004
> @@ -473,8 +473,10 @@
>  {
>  	int retval;
>  	
> +#ifdef CONFIG_BLOCK_DEVICES
>  	if (!(flags & MS_RDONLY) && bdev_read_only(sb->s_bdev))
>  		return -EACCES;
> +#endif
>  	if (flags & MS_RDONLY)
>  		acct_auto_close(sb);
>  	shrink_dcache_sb(sb);
> @@ -588,6 +590,7 @@
>  	return (void *)s->s_bdev == data;
>  }

Tons of stuff here make sense only for block-based filesystems (e.g. the
function immediately above ;-).  Ifdef, or, better yet, move to fs/block_dev.c

> +cond_syscall(sys_fsync)
> +cond_syscall(sys_fdatasync)

Huh?  They should work for network filesystems.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/