Re: Suspected bug infilesystems (UFS,ADFS,BEFS,BFS,ReiserFS) related to sector_t being unsigned, advice requested

From: Oleg Drokin
Date: Tue Jan 06 2004 - 16:36:55 EST


Hello!

Mike Fedyk <mfedyk@xxxxxxxxxxxxx> wrote:
MF> On Tue, Jan 06, 2004 at 12:28:34PM +0100, Jesper Juhl wrote:
>> --- linux-2.6.1-rc1-mm2-orig/fs/reiserfs/inode.c 2004-01-06 01:33:08.000000000 +0100
>> +++ linux-2.6.1-rc1-mm2/fs/reiserfs/inode.c 2004-01-06 12:16:16.000000000 +0100
>> @@ -574,11 +574,6 @@ int reiserfs_get_block (struct inode * i
>> th.t_trans_id = 0 ;
>> version = get_inode_item_key_version (inode);
>>
>> - if (block < 0) {
>> - reiserfs_write_unlock(inode->i_sb);
>> - return -EIO;
>> - }
>> -
MF> Did you check the locking after this is removed?

Locking should be fine.
As I remember, we take this lock near reiserfs_get_block() entrance,
and then drop it on exit.

MF> Maybe after the sector_t merges, this code covered a case that is left open
MF> now...

This code was never executing anyway.

Bye,
Oleg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/