Re: Suspected bug infilesystems (UFS,ADFS,BEFS,BFS,ReiserFS) related to sector_t being unsigned, advice requested

From: Oleg Drokin
Date: Wed Jan 07 2004 - 07:10:58 EST


Hello!

On Wed, Jan 07, 2004 at 02:00:35PM +0300, Hans Reiser wrote:

> >>can we get gcc to issue us a warning? there might be other stuff
> >>lurking around also....
> >If you add -W switch to CFLAGS, you'd get A LOT of more warnings.
> >Also just reading manpage on gcc around description of that flag will
> >give you a list of options to individually turn on certain check types.
> >Also gcc 3.3 have this sort of " unsigned < 0 | unsigned > 0" checks on by
> >default, I think.
> Sigh, this means that not one member of our team bothered to compile
> with -W and cleanup things that were found? Sad. This is what happens

Well, I was doing these sorts of stuff and cleaning all stuff that I thought
was important enough.
Both on kernel code and progs code.
Also reiser4progs include -W switch by default (and -Werror as well) I think.
At least that was the case back in September.

Bye,
Oleg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/