Re: [PATCH] drivers/scsi/advansys.c check_region() fix

[Gene Heskett]

On Wednesday 07 January 2004 18:26, Rusty Russell wrote:
>In message <20031230134433.GA22187@xxxxxxxxxxxxxx> you write:
>> Another trivial check_region() fix verified by Gene
>
>And almost certainly wrong.

I'm the "Gene", Rusty.  What symptoms would I see if its wrong?  
Memory leak?  Instability?  My dog falls over before his time?  My 
pickup throws a rod?

In my case, its only running a small 4 tape Seagate changer, so it 
doesn't get a lot of exersize other than by amanda's nightly run.

>The *point* of request_region() is that you do it before any I/O to
>the region.
>
>So you can't release it before calling AscGetChipVersion().
>
>Converting this driver is quite a bit of work, since you have to
> trace down every path which uses the region and make sure it's
> covered.  The fact that it's formatted like an angry haiku doesn't
> help.

I noticed, gawd, that looks like a bowl of spagetti and I'm nowhere 
near the coder you fellows are.  But it did get rid of the compiler 
warnings about check_region().

-- 
Cheers, Gene
AMD K6-III@500mhz 320M
Athlon1600XP@1400mhz  512M
99.22% setiathome rank, not too shabby for a WV hillbilly
Yahoo.com attornies please note, additions to this message
by Gene Heskett are:
Copyright 2003 by Maurice Eugene Heskett, all rights reserved.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/