Re: [PATCH] fs/fcntl.c - remove impossible <0 check in do_fcntl -arg is unsigned.

[Hans Reiser]

Code is like poetry --- bloat needs to come out of it, and a rigorous 
discipline of removing all unnecessary complexity from it needs to be 
made a habit so that the exact meaning  of it will be seen by all.

Boy was that pompous.;-) Oh well, I'd like the reiserfs portions of his 
patch to be accepted, and I'll forward them to you in a few days.  
Please consider accepting them.

Hans

Jesper Juhl wrote:

> On Wed, 7 Jan 2004, Linus Torvalds wrote:
>  
>
>
> > The fact that the compiler can optimize
> > away one of the tests if the type is right i2Ds fine. It seems to be
> > draconian to remove code that is correct and safe, especially when the
> > code has no real downsides to it.
> >    


--
Hans


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/