Re: [PATCH] sysfs sound class patches - [0/2]

[Greg KH]

On Thu, Jan 08, 2004 at 06:33:44PM +0100, Takashi Iwai wrote:
> At Wed, 7 Jan 2004 15:21:37 -0800,
> Greg KH wrote:
> > 
> > Here are 2 sysfs sound class patches against 2.6.1-rc2 (but should apply
> > to 2.6.0) that add sysfs support for OSS and ALSA drivers.  This enables
> > udev to see sound devices and create nodes for them.
> > 
> > I've divided it up into 2 patches:
> > 	- sound support for OSS drivers
> > 	- sound support for ALSA drivers
> > 
> > The ALSA driver patch requires the OSS driver (due to where struct
> > sound_class is declared),
> 
> oh, sound_core.c is not the OSS driver ;)

Heh, but the changes I made to it are in the OSS specific parts :)

> >  and it also modifies the i810 ALSA sound
> > driver to provide a symlink in sysfs to the pci device being controlled
> > by the device node.
>  
> it looks nice and easy.  i'll do that for all pci drivers, too, once
> when these patches are merged.

Thanks.

> > I can provide patches to the other ALSA drivers to also add this
> > information, as it's quite useful if you have more than one sound device
> > in your system at once.
> 
> not only pci but also isapnp devices can provide dev pointer.

Exactly.  So does USB.

> in that case, should the driver gives symlinks of each isapnp devices,
> too?

Yes.  If the dev pointer is valid, the driver core will create the
symlinks.

> a module usually holds one isapnp card struct and several isapnp
> devices below it.  but, hmm, it will need far more codes...

Just set the dev pointer to the device that is associated with the sound
device.  That's the best you can do.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/