Re: [linux-usb-devel] Re: USB hangs

From: Matthew Dharm
Date: Sun Jan 11 2004 - 18:32:31 EST


On Sun, Jan 11, 2004 at 03:25:06PM -0800, David Brownell wrote:
> Alan Cox wrote:
> >On Sul, 2004-01-11 at 00:23, Matthew Dharm wrote:
> >
> >>Where is USB kmalloc'ing with GFP_KERNEL? I thought we tracked all those
> >>down and eliminated them.
> >
> >
> >Not sure. I just worked from tracebacks. I needed it to work rather
> >than having the time to go hunting for specific faults. Plus I'd
> >argue PF_MEMALLOC is a better solution anyway.
>
> It certainly seems like a more comprehensive fix for that
> particular class of problems! :)

Is it really more comprehensive? As I see it, it will only affect code
executed in the context of the usb-storage thread. But, what about code
which is invoked in tasklets or other contexts?

Matt

--
Matthew Dharm Home: mdharm-usb@xxxxxxxxxxxxxxxxxx
Maintainer, Linux USB Mass Storage Driver

I'm just trying to think of a way to say "up yours" without getting fired.
-- Stef
User Friendly, 10/8/1998

Attachment: pgp00000.pgp
Description: PGP signature