Re: [PATCH] 2.6.1 (not 2.4.24!) mremap fixes broke shm alias mappings

From: Linus Torvalds
Date: Mon Jan 12 2004 - 20:44:01 EST




On Tue, 13 Jan 2004, Bart Oldeman wrote:
>
> We've already been discussing and playing with a cleaner alternative to
> mremap that works too (mmap'ing a file on tmpfs, perhaps via
> shm_open()). It's just that it's difficult to explain to users why DOSEMU
> worked on 2.6.0 and suddenly stopped working with the same configuration
> on 2.6.1.

Oh, please keep on using the mremap(ptr, 0, s) thing to create aliases.
There's nothing really wrong with it, and as long as we just document it
in the sources, it shouldn't break again.

> -- the consensus amongst DOSEMU developers seems to be that you should
> feel free to disallow this funny old_len==0 case in 2.7 if you like.

It's potentially useful, and if we'll have a backwards compatibility issue
anyway, there's no reason to remove it.

Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/