Re: [2.6 patch] fix a drivers/char/isicom.c compile warning
From: Angelo Dell'Aera
Date: Tue Jan 13 2004 - 06:53:36 EST
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Mon, 12 Jan 2004 22:38:28 -0200
Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx> wrote:
>> I thought about it, but I wasn't sure whether changing a driver to be
>> more readable in _one_ place and making the code there different from
>> the coding style used in the rest of the driver is really an
>> improvement (and no, I don't want to clean the whole driver...)?
>
>Humm, IMHO it is better to get it with mixed style as long as the changes that
>"break" the style are for the correct style, but this, of course, for purely
>unmaintained stuff, like... isicom.c :-) For maintained stuff it becomes a
>pain in the ass for the maintainer, that should try to follow CodingStyle, but
>as we know, not always do.
I started cleaning isicom.c in such a way as to be more "CodingStyle
compliant" but it's a hard pain... the fix from Adrian is still in.
Hope to release it in a reasonable time.
Regards.
- --
Angelo Dell'Aera 'buffer'
Antifork Research, Inc. http://buffer.antifork.org
PGP information in e-mail header
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFAA9ptpONIzxnBXKIRAhlqAJ9jefAfKxXeLJYb0SCpqBp8EGfN0QCfdvuo
ToB15Ba8cV73AMOpbcjAe4I=
=fXgy
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/