Re: [ANNOUNCE] udev 013 release

[Nuno Silva]

Hi!

Greg KH wrote:
> On Wed, Jan 14, 2004 at 07:23:11PM +0000, Nuno Silva wrote:
>
> > This would be nice but I think that full info for every new hotplugged 
> > device is even better. It's only 1 line :-)
>
>
> Heh, care to make that one line patch?  :)

Ehehehe I was talking about the extra line ending up in syslog. :-)

Anyway, attached is a simple patch that outputs 50% of what I'd like to 
see - still missing the SYSFS_model, serial, etc because 
sysfs_get_classdev_attributes didn't work at my first try, but that's my 
faulty C showing :)

Thanks,
Nuno Silva
diff -Naur udev-013.orig/logging.c udev-013/logging.c
--- udev-013.orig/logging.c	2003-12-15 21:57:35.000000000 +0000
+++ udev-013/logging.c	2004-01-15 02:52:36.000000000 +0000
@@ -27,8 +27,6 @@
 #include <syslog.h>
 #include "udev.h"
 
-#ifdef DEBUG
-
 static int logging_init = 0;
 static unsigned char udev_logname[42];
 
@@ -55,4 +53,3 @@
 	return 1;
 }
 
-#endif
diff -Naur udev-013.orig/namedev.c udev-013/namedev.c
--- udev-013.orig/namedev.c	2004-01-13 22:52:57.000000000 +0000
+++ udev-013/namedev.c	2004-01-15 07:40:40.000000000 +0000
@@ -748,6 +748,13 @@
 		udev->owner[0] = 0x00;
 		udev->group[0] = 0x00;
 	}
+	/* notify syslog and report some of the configuration: */
+	/* FIXME: add SYSFS_* nodes, too */
+	dbg_syslog("New device! Metrics: BUS='%s', ID='%s', KERNEL='%s'",
+	    sysfs_device->bus, sysfs_device->bus_id, class_dev->name);
+	dbg_syslog("name, '%s' is going to have owner='%s', group='%s', mode = %#o",
+	    udev->name, udev->owner, udev->group, udev->mode);
+
 	dbg("name, '%s' is going to have owner='%s', group='%s', mode = %#o",
 	    udev->name, udev->owner, udev->group, udev->mode);
 
diff -Naur udev-013.orig/udev.h udev-013/udev.h
--- udev-013.orig/udev.h	2004-01-13 01:50:34.000000000 +0000
+++ udev-013/udev.h	2004-01-14 23:22:08.000000000 +0000
@@ -25,9 +25,14 @@
 
 #include "libsysfs/libsysfs.h"
 #include <sys/param.h>
+#include <syslog.h>
+
+#define dbg_syslog(format, arg...)							\
+	do {										\
+		log_message (LOG_DEBUG , "%s: " format , __FUNCTION__ , ## arg);	\
+	} while (0)
 
 #ifdef DEBUG
-#include <syslog.h>
 #define dbg(format, arg...)								\
 	do {										\
 		log_message (LOG_DEBUG , "%s: " format , __FUNCTION__ , ## arg);	\