Re: [patch] v4l-05 add infrared remote support

[Roman Zippel]

Hi,

On Thu, 15 Jan 2004, Gerd Knorr wrote:

> diff -u linux-2.6.1/drivers/media/Kconfig linux/drivers/media/Kconfig
> --- linux-2.6.1/drivers/media/Kconfig	2004-01-14 15:05:10.000000000 +0100
> +++ linux/drivers/media/Kconfig	2004-01-14 15:09:35.000000000 +0100
> @@ -49,5 +49,11 @@
>  	default VIDEO_BT848
>  	depends on VIDEO_DEV
>
> +config VIDEO_IR
> +	tristate
> +	default y if VIDEO_BT848=y || VIDEO_SAA7134=y
> +	default m if VIDEO_BT848=m || VIDEO_SAA7134=m
> +	depends on VIDEO_DEV
> +
>  endmenu
>

This can also be written as:

config VIDEO_IR
	def_tristate VIDEO_BT848 || VIDEO_SAA7134

def_tristate is the same as tristate & default ...
The dependency is redundant as the other options already depend on it.

Another possibility is to use select:

# selected as needed
config VIDEO_IR
	tristate

config VIDEO_BT848
	...
	select VIDEO_IR

This has the advantage that adding/removing drivers only requires changes
at a single place.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/